Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cache extrinsic events #1327

Merged
merged 2 commits into from
Jan 3, 2024
Merged

fix: cache extrinsic events #1327

merged 2 commits into from
Jan 3, 2024

Conversation

f-squirrel
Copy link
Contributor

No description provided.

@f-squirrel f-squirrel requested a review from a team as a code owner December 21, 2023 16:05
@cla-bot-2021
Copy link

cla-bot-2021 bot commented Dec 21, 2023

User @f-squirrel, please sign the CLA here.

niklasad1
niklasad1 approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, thanks

@f-squirrel
Copy link
Contributor Author

nice catch, thanks

Thank you. I have fixed Clippy; please review-rerun the CI.

@f-squirrel
Copy link
Contributor Author

@niklasad1 , it seems I am missing something here.
The CI fails on Clippy for the code that I did not change.
Is it supposed to be like that?

@niklasad1
Copy link
Member

niklasad1 commented Jan 3, 2024 •
edited
Loading

@f-squirrel

It's the new rustc release that caused lemme fix that and not related to your PR, sorry

You can wait either cherry-pick this commit: 9c55a5f or wait until #1334 is merged and rebase/merge your branch to master.

jsdw
jsdw approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, thank you :)

@niklasad1 niklasad1 merged commit 0d30635 into paritytech:master Jan 3, 2024
11 checks passed
@tadeohepperle tadeohepperle mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsdw jsdw jsdw approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@f-squirrel @niklasad1 @jsdw